ATLAS-4766: java.lang.IllegalStateException from JanuGraph while purg…#682
Open
sheetalshah1007 wants to merge 1 commit into
Open
ATLAS-4766: java.lang.IllegalStateException from JanuGraph while purg…#682sheetalshah1007 wants to merge 1 commit into
sheetalshah1007 wants to merge 1 commit into
Conversation
…ing entities at Atlas
sheetalshah1007
force-pushed
the
ATLAS-4766
branch
from
5a68da8 to
3bc4cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing entities at Atlas
What changes were proposed in this pull request?
Problem:
DeleteHandlerV1throwsjava.lang.IllegalStateExceptionwhen purging entities because it tries to access graph vertices/edges that have already been removed in the same transaction during batch operations.Solution:
isRelationshipEdge()method - Wrapped vertex type retrieval in try-catch to gracefully handleIllegalStateExceptionwhen vertices are already removeddeleteVertex()method - Addededge.exists()andoutVertex.exists()checks to skip edges with removed endpoints; wrapped loop in try-catch for resilienceHow was this patch tested?
New test suite
DeleteHandlerV1Test.java:testIsRelationshipEdgeWithPurgedEndpoint()- Verifies method handles purged endpoints safelytestPurgeManagerAfterSubordinateAlreadyPurged() -Tests sequential purge of related entitiestestBatchPurgeManagerAndSubordinates()- Tests batch purge of multiple entities in one transactionAll tests confirm no
IllegalStateExceptionis thrown during delete/purge operations.