[AURON #2352] Lock spills before new spiller#2350
Open
wForget wants to merge 2 commits into
Open
Conversation
wForget
changed the title
Comment on lines
+101
to
108
| let mut spills = self.spills.lock().await; | ||
| let spill = tokio::task::spawn_blocking(move || { | ||
| let mut spill = try_new_spill(&spill_metrics)?; | ||
| let offsets = data.write(spill.get_buf_writer())?; | ||
| Ok::<_, DataFusionError>(Offsetted::new(offsets, spill)) | ||
| }) | ||
| .await | ||
| .expect("tokio spawn_blocking error")?; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2352
Rationale for this change
try_new_spillalways usesspills.lenas thespill_id, so we should always lockspillsbeforetrying_new_spill.What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?