[Java] Increase CallTest sleep durations to keep test from being flaky#39016
[Java] Increase CallTest sleep durations to keep test from being flaky#39016scwhittle wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of the CallTest suite by extending timeout thresholds in simulated scenarios. Additionally, it cleans up the test code by removing redundant exception declarations that were not required by the implementation. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up the CallTest.java file by removing unnecessary throws UserCodeExecutionException declarations from several test helper classes. It also increases the timeout buffers for CallerExceedsTimeout, SetupExceedsTimeout, and TeardownExceedsTimeout from 1 second to 1 minute. The reviewer recommends reducing this timeout buffer to 5 seconds instead of a full minute to prevent the test suite from hanging or running extremely slowly during failures or regressions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| CallerExceedsTimeout(Duration timeout) { | ||
| this.timeout = timeout.plus(Duration.standardSeconds(1L)); | ||
| this.timeout = timeout.plus(Duration.standardMinutes(1L)); |
There was a problem hiding this comment.
Increasing the sleep duration by a full minute can cause the test suite to hang or run extremely slowly if the timeout execution fails to interrupt properly or if there is a regression. A smaller buffer, such as 5 or 10 seconds, is typically sufficient to prevent flakiness on busy CI machines while keeping test failures fast.
| this.timeout = timeout.plus(Duration.standardMinutes(1L)); | |
| this.timeout = timeout.plus(Duration.standardSeconds(5L)); |
|
|
||
| private SetupExceedsTimeout(Duration timeout) { | ||
| this.timeout = timeout.plus(Duration.standardSeconds(1L)); | ||
| this.timeout = timeout.plus(Duration.standardMinutes(1L)); |
There was a problem hiding this comment.
Increasing the sleep duration by a full minute can cause the test suite to hang or run extremely slowly if the timeout execution fails to interrupt properly or if there is a regression. A smaller buffer, such as 5 or 10 seconds, is typically sufficient to prevent flakiness on busy CI machines while keeping test failures fast.
| this.timeout = timeout.plus(Duration.standardMinutes(1L)); | |
| this.timeout = timeout.plus(Duration.standardSeconds(5L)); |
|
|
||
| private TeardownExceedsTimeout(Duration timeout) { | ||
| this.timeout = timeout.plus(Duration.standardSeconds(1L)); | ||
| this.timeout = timeout.plus(Duration.standardMinutes(1L)); |
There was a problem hiding this comment.
Increasing the sleep duration by a full minute can cause the test suite to hang or run extremely slowly if the timeout execution fails to interrupt properly or if there is a regression. A smaller buffer, such as 5 or 10 seconds, is typically sufficient to prevent flakiness on busy CI machines while keeping test failures fast.
| this.timeout = timeout.plus(Duration.standardMinutes(1L)); | |
| this.timeout = timeout.plus(Duration.standardSeconds(5L)); |
|
Example failure: Seems likely to be just racy so adding more padding to the sleep |
scwhittle
force-pushed
the
flaky_test
branch
3 times, most recently
from
a2d9d7b to
b4e17ba
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
…o timeout not being observed. Decrease configured timeouts from 1 minute to 1 second to speed up test execution.
1 participant
While modifying the test, remove unnecessary throws declarations
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.