Skip to content

Fix pip ResolutionTooDeep#39017

Open
aIbrahiim wants to merge 4 commits into
apache:masterfrom
aIbrahiim:fix/cloudml-deps-conflict
Open

Fix pip ResolutionTooDeep#39017
aIbrahiim wants to merge 4 commits into
apache:masterfrom
aIbrahiim:fix/cloudml-deps-conflict

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes: #38780

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@aIbrahiim aIbrahiim force-pushed the fix/cloudml-deps-conflict branch from edb2827 to e7232f5 Compare June 18, 2026 13:38
@aIbrahiim

Copy link
Copy Markdown
Contributor Author

Run TFT Criteo Benchmarks

@aIbrahiim aIbrahiim marked this pull request as ready for review June 18, 2026 18:34
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses recurring dependency resolution issues in the CloudML benchmark environment. By introducing a formal constraints file and updating dependency specifications in the requirements file, the build process is now more robust and less prone to complex resolution failures during package installation.

Highlights

  • Dependency Resolution Fix: Introduced a new constraints file to pin package versions, preventing pip's 'ResolutionTooDeep' errors during environment setup.
  • Requirements Update: Updated 'requirements.txt' to use version ranges for core dependencies, ensuring better compatibility and resolution.
  • Build Script Improvement: Refactored the 'installTFTRequirements' Gradle task to utilize the new constraints file instead of manual dependency filtering.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a constraints file (constraints.txt) to pin dependency versions for CloudML benchmarks, helping to avoid pip ResolutionTooDeep errors. It also updates requirements.txt with adjusted version bounds and simplifies the installation step in common.gradle to use this constraints file. The review feedback suggests documenting the usage of the constraints file within requirements.txt and adding a pin for tensorflow-serving-api in constraints.txt for completeness.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

tfx_bsl==1.16.1
tensorflow-transform==1.16.0
tensorflow>=2.16,<2.17
# Core TFT dependencies with version bounds

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent developers or automated scripts from hitting ResolutionTooDeep errors when installing these requirements directly, it is highly recommended to document that the constraints file should be used.

# Core TFT dependencies with version bounds.\n# Note: To avoid pip ResolutionTooDeep errors, always install using the constraints file:\n# pip install -c constraints.txt -r requirements.txt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this comment please?

Comment on lines +25 to +28
# TensorFlow ecosystem
tensorflow==2.15.1
tensorflow-metadata==1.15.0
tf-keras==2.15.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For completeness and to ensure consistent resolution of all TensorFlow ecosystem packages, consider pinning tensorflow-serving-api in the constraints file as well, since it is specified in requirements.txt.

# TensorFlow ecosystem\ntensorflow==2.15.1\ntensorflow-metadata==1.15.0\ntf-keras==2.15.1\ntensorflow-serving-api==2.15.1

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this generally LGTM, just had one comment

tfx_bsl==1.16.1
tensorflow-transform==1.16.0
tensorflow>=2.16,<2.17
# Core TFT dependencies with version bounds

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this comment please?

@aIbrahiim aIbrahiim requested a review from damccorm June 18, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The CloudML Benchmarks Dataflow job is flaky

2 participants