build: advertise LICENSE in sdist metadata#835
Open
Haricharanpanjwani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #755.
Summary
The sdist already ships the combined
LICENSEfile, butproject.license-filesonly advertisedLICENSE-wheel,NOTICE, andDISCLAIMER. That meant the generatedPKG-INFOLicense-Filemetadata under-reported the combined Apache 2.0 + bundled MIT attribution file used for the website UI components.This change adds
LICENSEtoproject.license-filesand adds a regression test to keep that metadata list from drifting.Changes
LICENSEtoproject.license-filesinpyproject.tomlValidation
python3 -m py_compile tests/test_release_config.pyXDG_CACHE_HOME=/tmp/xdg-cache UV_CACHE_DIR=/tmp/uv-cache uv run --with pytest pytest tests/test_release_config.py -q2 passed, 1 warning in 0.01sXDG_CACHE_HOME=/tmp/xdg-cache UV_CACHE_DIR=/tmp/uv-cache uv run python -m flit build --format sdistdist/apache_burr-0.42.0.tar.gztar -xOf dist/apache_burr-0.42.0.tar.gz 'apache_burr-0.42.0/PKG-INFO' | rg '^License-File:'\n - result includesDISCLAIMER,LICENSE,LICENSE-wheel, andNOTICE\n\n## Notes\n\n- The pytest run emitted an existingPytestConfigWarningabout unknown config optionasyncio_mode; it did not affect the test result.