CASSANDRA-21519: Return CorruptSSTableException if chunk metadata and file size are out of sync#4937
Open
nivykani wants to merge 1 commit into
Open
CASSANDRA-21519: Return CorruptSSTableException if chunk metadata and file size are out of sync#4937nivykani wants to merge 1 commit into
nivykani wants to merge 1 commit into
Conversation
…le size are out of sync
tejalchak
reviewed
Jul 20, 2026
| long realPosition = Math.min(channelSize, position); | ||
| int blockNo = (int) (realPosition / bufferSize); | ||
| if (position >= channelSize) | ||
| throw new CorruptSSTableException(null, channel.filePath()); |
There was a problem hiding this comment.
Would it help with triage to include some details in the exception
"chunk read past EOF: position=<> channelSize=<>"
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ThreadLocalReadAheadBuffer, in the rare case that chunk metadata and file size are out of sync (e.g. bytes erased from the file after chunk metadata is calculated), we’d enter an infinite loop.
The proposed fix is to throw a CorruptSSTableException if we’re trying to read past the end of a file, rather than clamping the read.
The Cassandra Jira