Repository navigation
fix off-by-one subtree check in prefixMap iterator remove - #743
Open
rootvector2 wants to merge 1 commit into
Open
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
The prefix view's iterator treated a subtree root whose bitIndex equals the prefix length in bits as the only matching entry and stopped early, skipping entries still in the view, and dereferenced the recomputed subtree without handling the null it returns once the prefix is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrefixRangeEntrySet.EntryIterator.remove()marks the iteration finished wheneverlengthInBits >= subtree.bitIndex, but a subtree root whosebitIndexequals the prefix length in bits is a branch node rather than the only matching entry (PrefixRangeEntrySet.iterator()uses the strict>for that same test and only then returns aSingletonIterator), so removingandesfromprefixMap("and")over the keysand, andes, android, androidsends the iteration afterandroidand silently leavesandroidsin the trie, andsubtree()returns null once no entry with the prefix is left so the followingsubtree.bitIndexread throws; found with a randomized differential test of prefix-view iterator removal against a filteredTreeMap, where 200000 random cases give about 3100NullPointerExceptions, 340 truncated iterations and 190 tries whose final content differs from the reference before this change, and 600000 cases are clean after it.mvn; that'smvnon the command line by itself.