Repository navigation
Conversation
Compute the final sublist end from the remaining element count instead of adding the partition size before bounding it. Add a virtual large-list regression that fails before the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListUtils.partition()slice using the remaining element count. The previousstart + sizecould overflow beforeMath.min.Integer.MAX_VALUE-element list test, so the failing case needs no large allocation.Jira: https://issues.apache.org/jira/browse/COLLECTIONS-901
This is separate from COLLECTIONS-673, which fixed overflow in
Partition.size(); this failure is inPartition.get().Validation
fromIndex(1073741825) > toIndex(-2147483646)and passes with this change. The exact code diff passed independent review;ListUtilsTestran 28 tests without failure.mvn -qon macOS/JDK 27.xmllint --noout src/changes/changes.xmlandgit diff --checkpassed.AI assistance
Kiro with Claude Opus 5.5 assisted with the initial code and regression test. A separate Kiro review checked the exact code diff and independently reproduced the failure before and success after the fix.
Checklist