feat: add merge append#699
Open
zhjwpku wants to merge 3 commits into
Open
Conversation
wgtmac
reviewed
Jun 16, 2026
| virtual Result<std::shared_ptr<FastAppend>> NewFastAppend(); | ||
|
|
||
| /// \brief Create a new MergeAppend to append data files and merge manifests. | ||
| virtual Result<std::shared_ptr<MergeAppend>> NewMergeAppend(); |
Member
There was a problem hiding this comment.
StaticTable also needs to override this and return NotSupported. Otherwise a read-only StaticTable inherits Table::NewMergeAppend(), creates a mutating snapshot update, and later hits the null catalog path during commit. The existing static-table test should cover this alongside NewFastAppend.
wgtmac
reviewed
Jun 16, 2026
Member
|
Let's rebase to resolve conflicts and perhaps address above findings. |
While adding merge append tests, it was discovered that FastAppend did not populate manifest count summary fields, thus add SnapshotUpdate::BuildManifestCountSummary and use it from FastAppend and MergingSnapshotUpdate, which is consistent with java implementation.
zhjwpku
force-pushed
the
support_merge_append
branch
from
2c14cdc to
4c3b27c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding merge append tests, it was discovered that FastAppend did not populate manifest count summary fields, thus add SnapshotUpdate::BuildManifestCountSummary and use it from FastAppend and MergingSnapshotUpdate, which is consistent with java implementation.