Skip to content

fix: validate transform parameters in metadata#757

Open
fallintoplace wants to merge 1 commit into
apache:mainfrom
fallintoplace:fix/validate-transform-params
Open

fix: validate transform parameters in metadata#757
fallintoplace wants to merge 1 commit into
apache:mainfrom
fallintoplace:fix/validate-transform-params

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • add Transform::Validate to reuse bind-time transform checks during metadata validation
  • reject invalid bucket/truncate parameters when parsing transform strings
  • make partition specs and sort orders reject non-positive bucket/truncate parameters during schema-bound validation

Validation

  • cmake -S . -B build-transform-params -G Ninja -DICEBERG_BUILD_BUNDLE=OFF -DICEBERG_BUILD_REST=OFF -DICEBERG_BUILD_SHARED=OFF
  • ctest --test-dir build-transform-params -R schema_test --output-on-failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant