Skip to content

fix(rest): align error handlers with Java implementation#763

Open
zhjwpku wants to merge 1 commit into
apache:mainfrom
zhjwpku:align_error_handlers
Open

fix(rest): align error handlers with Java implementation#763
zhjwpku wants to merge 1 commit into
apache:mainfrom
zhjwpku:align_error_handlers

Conversation

@zhjwpku

@zhjwpku zhjwpku commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

While reviewing #614, I noticed that PlanErrorHandler::Accept does not match the behavior of the Java implementation.

A detailed comparison with Java's ErrorHandlers revealed several gaps between iceberg-cpp and Iceberg Java. Some of these are oversights in the original implementation, while others correspond to improvements that were made later in Iceberg Java, including:

This PR closes those gaps and brings the error handling behavior in iceberg-cpp closer to the Java implementation.

While reviewing apache#614, I noticed that `PlanErrorHandler::Accept`
does not match the behavior of the Java implementation.

A detailed comparison with Java's `ErrorHandlers` revealed several
gaps between iceberg-cpp and Iceberg Java. Some of these are
oversights in the original implementation, while others correspond
to improvements that were made later in Iceberg Java, including:

* apache/iceberg#13143
* apache/iceberg#14927
* apache/iceberg#15051
* apache/iceberg#16059

This PR closes those gaps and brings the error handling behavior in
iceberg-cpp closer to the Java implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant