Make scan_plan_helper internal (#3541)#3553
Open
tanmayrauth wants to merge 1 commit into
Open
Conversation
scan_plan_helper is an internal helper for local scan planning, not a public extension point. Rename it to _scan_plan_helper to reflect its intended visibility and update its only caller in inspect.py. The method was introduced recently in d99936a and has not been part of any released public API, so no deprecation shim is required.
Member
I think the right issue number is |
rambleraptor
approved these changes
Jun 24, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
Easy peasy. Thanks for the PR!
abnobdoss
approved these changes
Jun 24, 2026
ebyhr
approved these changes
Jun 24, 2026
| return self._manifest_planner.partition_filters | ||
|
|
||
| def scan_plan_helper(self) -> Iterator[list[ManifestEntry]]: | ||
| def _scan_plan_helper(self) -> Iterator[list[ManifestEntry]]: |
Member
There was a problem hiding this comment.
nit: I feel _helper suffix is weird. The name should describe what it does, not that it's a helper. We could rename it to _plan_manifest_entries or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan_plan_helper is an internal helper for local scan planning, not a public extension point. Rename it to _scan_plan_helper to reflect its intended visibility and update its only caller in inspect.py.
The method was introduced recently in d99936a and has not been part of any released public API, so no deprecation shim is required.
Fixes: #3541
Rationale for this change
Are these changes tested?
Are there any user-facing changes?