fix(server-ng): eliminate unnecessary backpressure under concurrent clients#3692
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3692 +/- ##
=============================================
- Coverage 74.06% 60.29% -13.77%
Complexity 937 937
=============================================
Files 1301 1301
Lines 147464 136412 -11052
Branches 123017 112038 -10979
=============================================
- Hits 109224 82256 -26968
- Misses 34768 50601 +15833
- Partials 3472 3555 +83
🚀 New features to boost your workflow:
|
spetz
approved these changes
Jul 20, 2026
mmodzelewski
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel-safe commits:
on_acknow peeks → reads → revalidates → appliesatomically instead of popping before its awaits; a dropped driver (e.g.
canceled HTTP handler) no longer strands committed entries and panics the
shard. HTTP register/logout submit via detached tasks.
Serialized checkpoints: forced checkpoints in
on_replicateare gatedsingle-flight (concurrent
drain()s raced the sharedwal.tmprewrite),and a failed checkpoint no longer drops the prepare — that left a phantom
op that permanently gapped the commit frontier until the pipeline wedged.
Backpressure absorbed, not surfaced: submits arriving while an op is
mid-commit are queued (register, with its reply subscriber riding the
request queue) or simply pipelined (logout / requests, matching the wire
path) instead of bouncing transient
NotCaughtUp— which one-shot clientssaw as hard login/logout failures.