fix(ci): use portable fallbacks for bash-4 builtins and GNU sed in hook scripts#3694
Open
jiengup wants to merge 1 commit into
Open
fix(ci): use portable fallbacks for bash-4 builtins and GNU sed in hook scripts#3694jiengup wants to merge 1 commit into
jiengup wants to merge 1 commit into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3693
Rationale
Several hook scripts use
mapfile(bash >= 4) andsed -iwithout backup extension (GNU extension). On macOS stock bash 3.2 and BSD sed, these fail, blocking contributors from committing.What changed
mapfilecalls now guard withcommand -v mapfileand fall back to awhile IFS= read -rloop.sed -icalls is replaced by thesed -i.bak && rmpattern already established intrailing-whitespace.sh.Local Execution
prek run -a