Skip to content

refer to Apache Toree (Incubating) - #288

Merged
lresende merged 7 commits into
apache:masterfrom
pjfanning:incubating
Sep 25, 2026
Merged

lresende merged 7 commits into
apache:masterfrom
pjfanning:incubating

Conversation

@pjfanning

Copy link
Copy Markdown
Member

ASF Incubator requires this

Comment thread DISCLAIMER Outdated
@@ -1,4 +1,4 @@
Apache Toree is an effort undergoing incubation at the Apache Software
Apache Toree (Incubating) is an effort undergoing incubation at the Apache Software

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this change? The disclaimer is a template provided by the incubating PMC and disclaims right there that this is a project undergoing incubation? The issue is that we might have a couple of copies of this and we might need to validate all are properly in sync.

https://incubator.apache.org/policy/incubation.html#standard_disclaimer

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the examples in use that I found has the Incubating in the name
  • If I must remove this, I will
  • but the others are needed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undid this change

Comment thread README.md Outdated
Comment thread etc/templates/toree-assembly-pom.xml Outdated
-->
<description>
Apache Toree is a Jupyter Notebook kernel that provides interactive
Apache Toree (Incubating) is a Jupyter Notebook kernel that provides interactive

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required by policy? i was searching other podlings and from a handful, only one had this in their description.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the Disclaimer is embedded to the description on the generated pom with @disclaimer@

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, in practice, the name of the project is effectively 'Apache Toree (Incubating)' as opposed to Apache Toree or Toree.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To phrase this another way - on release votes and other reviews, you won't get -1s for saying Incubating too often but you can get -1s for omitting it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't disagree, but then we need to add to the other assembly (spark-monitor) ? For consistency?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not have time over the next few days or even this week to look at spark-monitor. Can we merge this as is though and get back to spark-monitor as a separate task?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undid this change due to incubation text being there

I got claude to investigate the spark monitor job and got it to fix up the pom there

I would still recommend that these files are verified before a release vote is started.

pjfanning and others added 5 commits September 24, 2026 16:03
Added a disclaimer section regarding the incubation status of Apache Toree.
Removed the detailed disclaimer about Apache Toree's incubation status and replaced it with a link to a separate DISCLAIMER file.
Keep DISCLAIMER's paragraphs in the sbt-generated POM descriptions instead
of collapsing them onto one line, matching the assembly POM rendered from
etc/templates/toree-assembly-pom.xml. sbt's POM pretty-printer collapses
whitespace, so makePom writes the description back line by line.

Give the spark-monitor-plugin POM its own summary, and set organizationName
so <organization> names the ASF rather than repeating the groupId.

Drop "(Incubating)" from the assembly POM summary: the incubation
disclaimer that follows it is enough.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pjfanning and others added 2 commits September 24, 2026 16:06
Bintray shut down in 2021 and the old repo.typesafe.com releases URL is not
needed: every dependency resolves from Maven Central. Dropping them also
removes them from the <repositories> section of the published POMs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lresende
lresende merged commit c9437e3 into apache:master Sep 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants