fix: Populate record_count for parquet source files - #929
Open
zhang-arvin wants to merge 1 commit into
Open
Conversation
Fixes apache#926: InternalDataFile construction in ParquetConversionSource never set recordCount, so targets registered every file with record_count = 0 and optimized count(*) returned 0 on non-empty tables. Sum BlockMetaData.getRowCount() from the parquet footer and set it on both full-sync and incremental-sync file construction paths.
Contributor
|
@zhang-arvin can you add or update some existing tests to ensure we don't regress in the future? |
zhang-arvin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #926
What changes were proposed in this pull request?
ParquetConversionSourcenever populatedrecordCounton theInternalDataFiles it creates (both the full-sync and incremental paths), leaving it at the primitive default of 0. Both targets serialize that faithfully, so every registered file showedrecord_count = 0and engines answering aggregates from metadata (Spark's optimizedcount(*), Iceberg's.files, Delta'snumRecords) returned 0 rows for non-empty tables.How was this patch tested?
./mvnw -pl xtable-core -am -DskipTests compileITParquetConversionSourcesuite covers the conversion paths (local run pending CI).