[Bug] Skip incremental sync when delta source has no new commits - #930
Open
zhang-arvin wants to merge 1 commit into
Open
[Bug] Skip incremental sync when delta source has no new commits#930zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
Fixes apache#928: getCommitsBacklog computed start = lastSyncVersion + 1 with no start <= end guard, so a re-sync with no new commits passed an inverted version range [n+1, n] to Delta Kernel's getChanges, which failed with "Invalid version range". With no new commits the sync is now a successful no-op, matching the Hudi and Parquet sources.
Contributor
|
Let's add a basic test to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
What changes were proposed in this pull request?
DeltaKernelConversionSource.getCommitsBacklogcomputed the incremental range asstart = versionAtLastSyncInstant + 1,end = latestVersionwith nostart <= endguard. With no new commits since the last sync, the range became[n+1, n]and Delta Kernel'sgetChangesrejected the inverted interval withInvalid version range, breaking the documented pattern of calling sync after every write / on a schedule.The fix detects
versionAtLastSyncInstant >= latestVersion, logs that there is nothing to sync, and returns an empty commits backlog, making the no-op sync successful — matching the behavior of Hudi and Parquet sources.How was this patch tested?
./mvnw -pl xtable-core -am -DskipTests compileITDeltaKernelConversionSource/TestDeltaKernelSyncsuites cover incremental sync (local run pending CI).