Repository navigation
JSPWIKI-1206 JSPWIKI-1221 Migrate from NekoHTML to htmlunit-neko - #548
Open
arturobernalg wants to merge 4 commits into
Open
arturobernalg wants to merge 4 commits into
arturobernalg wants to merge 4 commits into
Conversation
|
@arturobernalg fyi currently working on 5.7.0; this will include some limits (https://github.com/HtmlUnit/htmlunit-neko#upgrade-notes-within-5x) to avoid dos attacks. If you like you can test with the latest snapshot - the release is planned for the next weekend... |
arturobernalg
force-pushed
the
feature/JSPWIKI-1206
branch
from
October 31, 2026 18:03
bc9ab4e to
aca2d15
Compare
org.codelibs:nekohtml is no longer maintained. Use org.htmlunit:neko-htmlunit, which needs Java 17 like the rest of the project. The new parser does not recognise the SAX validation feature that JDOM's XMLReaderSAX2Factory sets, and reports a null namespace URI for the attributes, which JDOM rejects. HtmlStringToWikiTranslator now gives JDOM its own reader factory, wrapping the parser in a filter that turns those URIs into empty strings. Element names are now lower case, as in XHTML, so the few hard coded upper case names in the translator are lower case too. jspwiki-main declared the dependency without using it, so it is dropped there.
arturobernalg
force-pushed
the
feature/JSPWIKI-1206
branch
from
November 3, 2026 19:37
aca2d15 to
4c89c2d
Compare
|
htmlunit-neko 5.7.0 is released |
5.7.0 limits the input the parser accepts, which guards against denial of service with crafted HTML, and drops the first line break after <pre>, as the HTML specification says. The tests of <pre> expect one line break less.
Member
Author
|
Updated to htmlunit-neko 5.7.0. The only change in behaviour is that the first line break after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.codelibs:nekohtml is no longer maintained. This moves to org.htmlunit:neko-htmlunit 5.6.0, which needs Java 17 like the rest of the project. It is only used by jspwiki-wysiwyg, to turn the HTML of the WYSIWYG editor into XHTML; jspwiki-main declared the dependency without using it, so it is dropped there. The line in LICENSE is updated.
Changes in HtmlStringToWikiTranslator:
Tests: no test changes. The 18 tests of HtmlStringToWikiTranslatorTest pass, as before, and so do the suites of jspwiki-util, jspwiki-event, jspwiki-main and jspwiki-markdown. Names with a namespace prefix, such as the o:p of pasted Word content, fail in JDOM both before and after this change. I did not build the WAR.