Repository navigation
JSPWIKI-1320 Diff a version of a page with the one before it in its R… - #572
Open
arturobernalg wants to merge 2 commits into
Open
arturobernalg wants to merge 2 commits into
arturobernalg wants to merge 2 commits into
Conversation
…SS feed The description of an entry in the RSS feed of a page took the version before the one described as version - 1. When that version had been deleted, reading it failed with a ProviderException, which was logged twice, and its text was taken as empty, so the entry showed the whole page as added. The entry is now diffed against the latest version that still exists before the one described. A page without an earlier version is described as created, as before.
arturobernalg
force-pushed
the
bug/JSPWIKI-1320
branch
from
November 3, 2026 19:37
539b61e to
560bbc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description of an entry in the RSS feed of a page took the version before the one described as
version - 1, as the FIXME inDefaultRSSGeneratorsaid. When that version had been deleted, reading it failed with aProviderException, which was logged twice, and its text was taken as empty, so the entry showed the whole page as added.The entry is now diffed against the latest version that still exists before the one described. A page without an earlier version is described as created, as before.
Measured with
VersioningFileProviderand theSvnStyleDiffProvider: a page saved three times with version 2 deleted. On master the entry for version 3 shows the line that did not change as added; with this change it is shown as unchanged. The newRSSGeneratorVersionsTesthas three tests; on master the one with the deleted version fails and the other two pass, with this change all three pass, andRSSGeneratorTeststill passes. I did not run the whole test suite.https://issues.apache.org/jira/browse/JSPWIKI-1320