Repository navigation
JSPWIKI-1324 Do not let the select lists be wider than their form - #578
Open
arturobernalg wants to merge 2 commits into
Open
arturobernalg wants to merge 2 commits into
arturobernalg wants to merge 2 commits into
Conversation
The rule for the select lists of a form did not limit their width, so on a narrow screen the lists of the time zone and the time format of the user preferences ended past the right edge. They are never wider than their form now.
Contributor
|
Works in Firefox and Safari. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSPWIKI-1324: the time zone and time format lists of the user preferences page are wider than a narrow screen. One of the points of JSPWIKI-1099 (responsive design of that page).
The rule
.form-group selectinforms.lessdid not limit the width, so each list is as wide as its longest option. It hasmax-width: 100%now.Measured with the WAR on Tomcat 10.1, loading
UserPreferences.jspin Chromium and taking the right edge of every element that is notposition: fixed:The page does not scroll sideways on master either (its scroll width is the width of the screen). Not tested: Firefox, Edge and Safari, other pages with a select list in a form, how the lists look at those widths (only the position of their edges was measured), and no automated test covers a stylesheet.
https://issues.apache.org/jira/browse/JSPWIKI-1324 (related to JSPWIKI-1099)