Repository navigation
fix(tools/gitlab): address review follow-up on pagination docstring, short pages, and issue template - #1441
Conversation
…short pages, and issue template
…emplate.md Generated-by: Claude Opus 5
potiuk
left a comment
There was a problem hiding this comment.
Thanks — both follow-ups from #1369 are closed: with an explicit --limit the loop now keeps paging through short pages until the limit or the last page, max_pages only caps unlimited fetches (where the notice's "use --limit" remedy actually works), and the new test covers it. The docstring, SPDX placement and closing sentence are fixed too.
I pushed one small fixup on top (7eabef3): the change had also dropped the *generated with [DocToc](…)* suffix from the TOC title that every other doc keeps, so I restored it. Merging.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
Addresses the two non-blocking follow-up observations from maintainer review in PR #1369:
1.
tools/gitlab/issue-template.mdSPDX-License-Identifierheader above the doctoc Table of Contents block to conform to standard ASF file layout across the repository.2.
tools/gitlab/src/magpie_gitlab/client.py&tools/gitlab/tests/test_client.pytest_get_paged_json_with_limit_fewer_than_pagedocstring from stating that it "emits notice" to "emits no notice", matching the actual assertion (err == "").get_paged_jsonto continue fetching subsequent pages when explicit--limitis specified and a short page (<100 items) is encountered withX-Next-Pageset.mathimport.test_get_paged_json_short_page_continues_until_limitto verify multi-page collection across short pages.All 61 unit tests, mypy static typing, and ruff checks pass cleanly.