Repository navigation
fix(skill-evals): align code-review footer fixtures with the contributing-guide link - #1503
Merged
Merged
Conversation
…ting-guide link #1407 replaced the Airflow-specific `contributing-docs/05_pull_requests.rst` link in the code-review footer with `[Contributing guide](<upstream_contributing_docs_url>)`, but the step-7b attribution eval still told the grader the footer ends with the Airflow pull-requests doc, and its "footer present" fixtures carried the old link text. Describe the link by its config key and use the current link text in the fixtures. The suite passes 4/4. Generated-by: Claude Opus 5
potiuk
added
capability:review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contributing-docs/05_pull_requests.rstlink in thepr-management-code-reviewAI-attribution footer with[Contributing guide](<upstream_contributing_docs_url>), but the step-7b attribution eval was left behind: its grader prompt still said the footer ends with the Airflow pull-requests doc, and the two "footer present" fixtures still used the old link text.upstream_contributing_docs_url, dropped when unset), and the fixtures use the current[Contributing guide](...)link text (still an Airflow URL, as the example project).Found while running the code-review skill on a stale checkout, where the footer linked a file that doesn't exist in Magpie.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowTest plan
prekhooks pass on the commitstep-7b-review-body-attribution4/4 (Claude-graded)Linked issues
Follow-up to #1407.
Generative AI disclosure: drafted with Claude Code; reviewed by the author.
🤖 Generated with Claude Code