fix(release-vote-draft): keep CVE IDs and security framing out of the expedited reason - #1509
Merged
Merged
Conversation
… expedited reason release-vote-draft copied the release manager's --expedited reason into the [VOTE] email and the planning-issue comment, both public. A reason such as "Critical security fix for CVE-2026-12345" therefore broke the embargo before the advisory shipped, and the eval expected exactly that. Golden rule 4 and Steps 2 and 3 now say the reason names no CVE and does not call the release a security fix until the advisory ships (AGENTS.md, Confidentiality): it is written neutrally, keeps any approval the RM cited, and the RM is told what was left out. The two expedited cases expect the neutral reason, and an assertion in both suites checks that no CVE ID or security framing reaches the public text. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-vote-draftcopied the release manager's--expeditedreason verbatim into the[VOTE]email and the planning-issue comment, and both are public.If the reason named a CVE ID or described the release as fixing a security problem, the skill published that before the embargo lifted.
The eval expected that output, so the model failed both expedited cases (on
maintoo) by correctly leaving the CVE out.Summary
Test plan
release-vote-draftstep-2 (3/3) and step-3 (3/3). Step-2 case-2 failed once on bracket formatting, then passed twice.🤖 Generated with Claude Code