Repository navigation
feat(i18n-ko): native surfaces and E2E fixtures #3980
Description
Problem
Native surfaces and E2E fixtures have no ko coverage. Startup dialogs, quit/boot messages, and fixtures still assume zh/en only, so auto + ko may regress to en or show wrong fallback.
Desired outcome
- Carry resolved
kothrough startup/quit/boot dialogs and persistedDesktopLocalePreference(as feat(i18n): add Traditional Chinese locale #3853 did forzh-TW) - Preserve canonical
koE2E fixture flags inapps/desktop/e2e/fixtures.ts/e2e-fixture.ts(no lowercasing bug likezh-CN/zh-TWfix in feat(i18n): add Traditional Chinese locale #3853 review) - Explicit
kofor non-catalog native fallbacks: Agent Graph, WorkHub, MCP, readiness, notifications (same list as feat(i18n): add Traditional Chinese locale #3853) - Add
kotozh-tw-locale-screenshots.ymlstyle workflow or extend existing one for Korean screenshots (macos-15, real Settings screenshots as artifact)
Alternatives or workarounds
Leave native/E2E in en/zh and accept untested ko paths.
Acceptance criteria
-
auto+ko-KRsystem →kobefore settings are loaded (startup dialogs correct) - E2E fixture
koflag preserved (notoLowerCase→nullbug) -
apps/desktop/e2e/zh-tw-locale-screenshots.spec.tsstyle spec added forkoor extended - Desktop locale-focused regression suites + CLI locale suites green with
ko
Parent: #3974
Activity
scs0209 commentedon Sep 1, 2026
Hi, I'd like to work on this issue.
I'll follow the same patterns as #3853 for
zh-TW(startup/quit/boot dialogs, E2E fixture flags, native fallbacks, and locale screenshot workflow). Happy to coordinate with any in-flightkolocale work (e.g. #3975 / #3978) so we don't duplicate effort.I'll start by reading through the #3853 changes and checking whether this should be stacked on top of that PR or
mainonce it lands.Thanks!
scs0209 commentedon Sep 1, 2026
take
scs0209 commentedon Sep 1, 2026
Working on this in draft PR #4515 (stacked on #3853).
scs0209:feat/i18n-ko-native-e2e-3980Happy to rebase/retarget once #3853 lands. Coordinating with #3975 for atomic
kointegration if needed.feat: 한국어(ko) 로케일 및 native/E2E 기반 구현 (apache#3980)
feat(i18n-ko): add Korean locale for native surfaces and E2E (apache#…
feat(i18n-ko): add Korean locale for native surfaces and E2E (apache#…
feat(i18n-ko): add Korean locale for native surfaces and E2E (apache#…
feat(i18n-ko): add Korean locale for native surfaces and E2E (apache#…
feat(i18n-ko): add Korean locale for native surfaces and E2E (apache#…
me2seeks commentedon Sep 20, 2026
Maintainer scope clarification from the #5451/#5075 investigation: #3980 owns both sides of the Storybook locale-global update in
apps/desktop/.storybook/preview.tsx.koto the toolbar locale items so Korean is selectable.kobranch in the decorator's locale mapping so selecting it resolves tokoinstead of falling through tozh-CN.Both changes are required together. This remains part of #3980's existing Storybook/E2E ownership and does not require reopening #5075. Korean screenshots should be captured only after the sibling catalog slices, including #3978's Astryx overrides, make the stack runnable without fallback shims.
scs0209 commentedon Sep 20, 2026
Done for the Storybook locale-global part called out above:
koto the toolbar locale items inapps/desktop/.storybook/preview.tsxkobranch in the decorator locale mapping (nozh-CNfallthrough)Holding Korean screenshots until sibling catalog slices (incl. #3978 Astryx overrides) make the stack runnable without fallback shims.
fix(i18n-ko): restore typecheck and verify native copy catalogs (apac…
fix(i18n-ko): translate startup progress window and cover it in tests (…
fix(i18n-ko): translate remaining native main-process copy (apache#3980)
fix(i18n-ko): address native copy review points on PR apache#4515 (ap…
fix(i18n-ko): address native copy review points on PR apache#4515 (ap…