Repository navigation
chore(provider): drop misleading "team" suffix from Alibaba Token Plan display names - #5239
Conversation
me2seeks
left a comment
There was a problem hiding this comment.
Automated review notice: This comment was posted by an automated review agent operated by me2seeks make. It is not an independent human review and does not replace one.
Summary
Drops the misleading "(团队版)" suffix from the Alibaba Token Plan zh-CN/zh-TW display names in favor of "中国站"/"国际站" and updates the matching Storybook fixture. Copy-only change in provider-display-copy.ts + one story fixture; the English names intentionally keep their distinct "(China)" wording. The renaming rationale (the plans are not team-scoped) matches the copy.
Findings
- [P2] This branch predates the main-line history rewrite: its tip's parent chain is not an ancestor of current
main, so GitHub will require a rebase before merge andmergeablewasUNKNOWNat snapshot time. The diff content is fine, but confirm mergeability after rebase —provider-display-copy.tsis a hot file and the sibling entries around it have moved.
Verdict
needs-discussion — copy change is correct; the branch must be rebased onto current main before it can merge.
|
This pull request has had no new commits for 30 days and has been marked stale. It will be closed in 7 days unless a new commit is pushed. Comments do not reset this timer: only a new commit does. If the pull request is intentionally long-lived, a maintainer can apply the |
Astro-Han
left a comment
There was a problem hiding this comment.
Automated review notice: This comment was posted by an automated review agent. It is not an independent human review and does not replace one.
No P0–P2 code issue was found at 181910ecf1b43c5f3608cbbd1d747328ca4fa37a. The change replaces four zh-CN/zh-TW Alibaba Token Plan names with regional labels and updates one Storybook fixture. Provider IDs, endpoints, authentication, English copy, descriptions and badges are unchanged; existing user-saved connection names are not migrated.
The prior rebase/mergeability finding is not supported by the current state: GitHub reports MERGEABLE, and automatic merging with main bacb1caed is clean. The actual merged display module retains all four new names. A rewritten history or an earlier UNKNOWN result alone does not establish a defect. The exact-head test run 34703965250 succeeded; the two skipped edited-event runs do not negate that completed test run.
Five existing settings-copy tests passed. An independent execution of the actual parent/head/merged modules checked 183 provider/locale and fallback combinations: only the four intended names changed, and the fixture keeps its provider ID and slug. Biome passed both changed files. No Desktop build, native UI interaction or live provider call was run. Alibaba's Personal quick start and Team quick start list the same Beijing text endpoints and sk-sp- key format; this does not establish identical model entitlements or international availability. No protocol epoch change is involved.
[P3] Clarify the attribution category. The PR explicitly checks substantive generative contribution and names Maka/deepseek-v4-pro, but its sole authored commit has no Generated-by: trailer. If that substantive declaration is intended, preserve the tool attribution in the commit. If this was only a wording edit, clarify the declaration instead: CONTRIBUTING explicitly exempts wording edits from substantive attribution. This is not a runtime defect.
Astro-Han
left a comment
There was a problem hiding this comment.
Approved at @Astro-Han's explicit request: the automated review of this exact head found no blocking (P0–P2) issues, and CI is green.
Astro-Han
left a comment
There was a problem hiding this comment.
Approved at @Astro-Han's explicit request: the automated review of this exact head found no blocking (P0–P2) issues, and CI is green.
|
This PR is approved, but it can't merge yet: its only
|
181910e to
7d6427b
Compare
Thanks for your help, I have rebaed the main. |
Astro-Han
left a comment
There was a problem hiding this comment.
Automated review notice: This comment was posted by an automated review agent. It is not an independent human review and does not replace one.
Incremental review to 7d6427be. This head rebases the previously reviewed change (181910ec) onto current main. The author's diff is byte-for-byte unchanged: the same two files, +5/-5. test now passes on this head. No new findings, and the earlier P3 about the AI-use disclosure stands as before.
Astro-Han
left a comment
There was a problem hiding this comment.
Approved at @Astro-Han's explicit request: the automated review of this exact head found no blocking (P0–P2) issues, and CI is green.
Summary
The zh-CN and zh-TW display names for
alibaba-token-plan-cnandalibaba-token-planinclude a "(团队版)" / "(團隊版)" suffix that suggests only the Team plan is supported. Aliyun's official docs confirm the Personal and Team plans share identical Base URLs andsk-sp-API key format, so a Personal plan subscription works without any difference. The suffix misleads users into thinking they need the Team plan and creates a false distinction between the two plans at the provider-selection level.This renames the entries to the regional naming already used by Alibaba Coding Plan:
alibaba-token-plan-cn→ Alibaba Token Plan 中国站alibaba-token-plan→ Alibaba Token Plan 国际站No logic changes; display copy only.
Verification
node_modulesalibaba-coding-plan-cn/alibaba-coding-plan(Coding Plan 中国站 / Coding Plan 国际站)AI use
Tool(s) and scope: Maka (deepseek-v4-pro) — analyzed the provider-display-copy module and proposed the rename after comparing official Aliyun docs for Personal and Team Token Plan editions.
Checklist
Does this PR entail a change in behavior?