Repository navigation
fix(ci): exercise production WorkHub browser click path - #5979
Merged
Sun-GLiang merged 2 commits intoOct 11, 2026
Merged
Conversation
Use BrowserSession navigation and OpenCLI native click preparation after Main closes instead of hand-dispatched down/up events. Keep the native-input and observed click-effect assertions, and dispose the acquired browser session during teardown. Generated-by: Codex (GPT-6)
4 of 6 tasks
Resolve the native smoke conflict by retaining the frame readiness wait inside the production browser click action lease. Generated-by: Codex (GPT-6)
Sun-GLiang
marked this pull request as ready for review
October 11, 2026 05:43
M4n5ter
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After Main closes, the WorkHub browser smoke manually dispatches a mouse down/up pair. That skips the target scrolling, hit testing and pointer positioning used by the production OpenCLI path.
Use
withBrowserPagefor navigation andpage.click, assertclick_method === 'cdp', and keep the observed “Clicked” effect assertion. Release the acquired browser session infinally.Preserve main's bounded two-frame readiness wait inside the click action lease so the background page stays active until the single native click. Main's color-managed screen capture checks are also retained.
Split from #5969 following its scope review. This changes only the smoke script.
Verification
16a8f5b84), all 56 browser-session, browser-IPC, browser-view-manager and WorkHub-presentation tests pass locally.AI use
Tool(s) and scope: Codex (GPT-6) authored the smoke change, resolved the main-branch conflict, and updated this description. The affected commits retain
Generated-by: Codex (GPT-6).Checklist
Does this PR entail a change in behavior?