Skip to content

fix(ci): exercise production WorkHub browser click path - #5979

Merged
Sun-GLiang merged 2 commits into
apache:mainfrom
Sun-GLiang:fix/workhub-native-click-smoke
Oct 11, 2026
Merged

Sun-GLiang merged 2 commits into
apache:mainfrom
Sun-GLiang:fix/workhub-native-click-smoke

Conversation

@Sun-GLiang

@Sun-GLiang Sun-GLiang commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

After Main closes, the WorkHub browser smoke manually dispatches a mouse down/up pair. That skips the target scrolling, hit testing and pointer positioning used by the production OpenCLI path.

Use withBrowserPage for navigation and page.click, assert click_method === 'cdp', and keep the observed “Clicked” effect assertion. Release the acquired browser session in finally.

Preserve main's bounded two-frame readiness wait inside the click action lease so the background page stays active until the single native click. Main's color-managed screen capture checks are also retained.

Split from #5969 following its scope review. This changes only the smoke script.

Verification

  • Root build, typecheck, lint, format and desktop/UI Knip checks pass locally on Node 24.
  • After merging main (16a8f5b84), all 56 browser-session, browser-IPC, browser-view-manager and WorkHub-presentation tests pass locally.
  • The native WorkHub browser presentation smoke passes on macOS, including all screen-pixel assertions and the production CDP click after Main closes. Main's color-managed capture fix resolves the earlier local screenshot failure.
  • Linux/Xvfb native smoke verification remains required in CI.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex (GPT-6) authored the smoke change, resolved the main-branch conflict, and updated this description. The affected commits retain Generated-by: Codex (GPT-6).

Checklist

  • Existing native-input and observed-click assertions are retained
  • Build, lint, format and typecheck pass locally
  • Native smoke passes on the Linux/Xvfb CI environment

Does this PR entail a change in behavior?

  • Yes
  • No — smoke coverage and teardown only

Use BrowserSession navigation and OpenCLI native click preparation after Main closes instead of hand-dispatched down/up events. Keep the native-input and observed click-effect assertions, and dispose the acquired browser session during teardown.

Generated-by: Codex (GPT-6)
@github-actions github-actions Bot added the effort/S Under 100 readable lines label Oct 7, 2026
Resolve the native smoke conflict by retaining the frame readiness wait inside the production browser click action lease.

Generated-by: Codex (GPT-6)
@Sun-GLiang
Sun-GLiang marked this pull request as ready for review October 11, 2026 05:43
@Sun-GLiang
Sun-GLiang merged commit fa26868 into apache:main Oct 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants