Skip to content

test(desktop): wait for a painted frame before the native smoke's CDP click #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liugddx merged 1 commit into from
Oct 9, 2026
Merged

test(desktop): wait for a painted frame before the native smoke's CDP click #6007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/desktop/scripts/workhub-browser-presentation-smoke.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,18 @@ async function run() {
await closedMainLease.ready;
await controller.navigate(`${url}/page?main-closed`);
const page = ownerParent.children.find((child) => 'webContents' in child && child.webContents !== owner).webContents;
// The view was just reparented into the floating window and navigated.
// Under Xvfb it may not have committed a frame (and hit-test data) in its
// new window yet, and Chromium drops input it cannot route. Wait for the
// page to load and render two frames before the single click. The timer
// only bounds the wait; it never adds a second click.
const readiness = await page.executeJavaScript(`new Promise((resolve) => {
const done = (via) => resolve({ via, visibility: document.visibilityState });
const frames = () => requestAnimationFrame(() => requestAnimationFrame(() => done('frames')));
setTimeout(() => done('timeout'), 2000);
if (document.readyState === 'complete') frames(); else addEventListener('load', frames, { once: true });
})`);
console.log(`Background page input readiness: ${readiness.via}, ${readiness.visibility}`);
const point = await page.executeJavaScript(`(() => { const r = document.querySelector('button').getBoundingClientRect(); return {x:r.x+r.width/2,y:r.y+r.height/2}; })()`);
await page.debugger.sendCommand('Input.dispatchMouseEvent', { type: 'mousePressed', ...point, button: 'left', buttons: 1, clickCount: 1 });
await page.debugger.sendCommand('Input.dispatchMouseEvent', { type: 'mouseReleased', ...point, button: 'left', buttons: 0, clickCount: 1 });
Expand Down