Skip to content

test(runtime-host): pin the settlement coverage window to the usage window #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Oct 9, 2026
Merged

test(runtime-host): pin the settlement coverage window to the usage window #6023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions packages/runtime-host/src/__tests__/hosted-execution-runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,15 @@ import { HostHostedExecutionRunner } from '../server/hosted-execution-runner.js'
test('hosted execution reads usage only after execution residencies settle', async () => {
const residency = deferred();
let usageRead = false;
const coverage = settlementCoverage();
const runner = new HostHostedExecutionRunner({
handlers: handlers({
usage: () => {
usageRead = true;
return usageSummary();
},
}),
runSettlementCoverage: settlementCoverage(),
runSettlementCoverage: coverage,
context: context(),
requestDrain: () => {},
waitForExecutionResidencies: () => residency.promise,
Expand Down Expand Up @@ -61,6 +62,10 @@ test('hosted execution reads usage only after execution residencies settle', asy
costUsd: 0.25,
});
assert.equal(usageRead, true);
// The completeness check must read the exact window the usage summary read
// (#5890 review): separating the two silently re-opens the delegated-Session
// undercount that window scoping closed.
assert.deepEqual(coverage.calls, [[100, 200]]);
});

test('a run-owned unsettled attempt refuses settlement with its fixed safe cause', async () => {
Expand Down Expand Up @@ -376,16 +381,24 @@ function usageSummary() {

/**
* The run-scoped incompleteness check's stub: a hosted execution owns no
* usage-unknown rows unless the test says otherwise.
* usage-unknown rows unless the test says otherwise. Calls are recorded so a
* test can pin the window the runner passed in.
*/
function settlementCoverage(
overrides: { usageMissingAttempts?: number; usagePartialAttempts?: number } = {},
) {
return async (_from: number, _to: number) => ({
usageMissingAttempts: 0,
usagePartialAttempts: 0,
...overrides,
});
const calls: Array<[number, number]> = [];
return Object.assign(
async (from: number, to: number) => {
calls.push([from, to]);
return {
usageMissingAttempts: 0,
usagePartialAttempts: 0,
...overrides,
};
},
{ calls },
);
}

function emptySkillInvocation() {
Expand Down