Skip to content

fix(desktop): provide WorkHub enablement in dock tests - #6053

Merged
Astro-Han merged 1 commit into
mainfrom
fix/ci-workhub-fixture
Oct 10, 2026
Merged

Astro-Han merged 1 commit into
mainfrom
fix/ci-workhub-fixture

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Restore Desktop CI compilation by mounting WorkHubEnablementProvider in the WorkHub dock test fixture instead of passing the retired enabled prop.

Refs #5936 and #5938. The dock now reads its switch from the existing provider, but the newly merged fixture still used the old API. This breaks build:main on main and downstream PRs with TS2769 at workhub-dock.test.ts:99 (first failing main run).

Only the test composition changes; production behavior, protocol and migration requirements are unchanged. Existing backdrop handoff assertions remain intact.

Verification

  • GitHub CI passed on the PR merge result: run 38048540622.

  • Reproduced the original TS2769 with npm run build on current main after installing locked dependencies and refreshing local incremental caches.

  • npm --workspace @maka/desktop run build — passed.

  • node --test --test-concurrency=4 dist/main/__tests__/workhub-dock.test.js dist/main/__tests__/workhub-enablement.test.js from apps/desktop — 16 passed.

  • npm --workspace @maka/desktop run typecheck — passed.

  • npm run format and npm run lint — passed, no fixes needed.

  • Full-repository tests and local Electron E2E were not run; CI covers its selected surfaces.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Maka (gpt-6.1-sol) diagnosed the failures, updated the test fixture, and ran verification.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Mount the existing WorkHub enablement provider instead of passing the retired enabled prop. This restores Desktop compilation after #5938 met the provider-owned switch from #5936 without changing production behavior.

Generated-by: Maka (gpt-6.1-sol)
@github-actions github-actions Bot added the effort/XS Under 10 readable lines label Oct 10, 2026
@Astro-Han Astro-Han mentioned this pull request Oct 10, 2026
4 of 6 tasks
@Astro-Han
Astro-Han marked this pull request as ready for review October 10, 2026 11:35
@Astro-Han
Astro-Han merged commit bacb1ca into main Oct 10, 2026
3 checks passed
@Astro-Han
Astro-Han deleted the fix/ci-workhub-fixture branch October 10, 2026 11:37
ggbdpq added a commit to ggbdpq/maka that referenced this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XS Under 10 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants