Repository navigation
fix(desktop): provide WorkHub enablement in dock tests - #6053
Merged
Merged
Conversation
me2seeks
approved these changes
Oct 10, 2026
ggbdpq
added a commit
to ggbdpq/maka
that referenced
this pull request
Oct 10, 2026
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Desktop CI compilation by mounting
WorkHubEnablementProviderin the WorkHub dock test fixture instead of passing the retiredenabledprop.Refs #5936 and #5938. The dock now reads its switch from the existing provider, but the newly merged fixture still used the old API. This breaks
build:mainon main and downstream PRs with TS2769 atworkhub-dock.test.ts:99(first failing main run).Only the test composition changes; production behavior, protocol and migration requirements are unchanged. Existing backdrop handoff assertions remain intact.
Verification
GitHub CI passed on the PR merge result: run 38048540622.
Reproduced the original TS2769 with
npm run buildon current main after installing locked dependencies and refreshing local incremental caches.npm --workspace @maka/desktop run build— passed.node --test --test-concurrency=4 dist/main/__tests__/workhub-dock.test.js dist/main/__tests__/workhub-enablement.test.jsfromapps/desktop— 16 passed.npm --workspace @maka/desktop run typecheck— passed.npm run formatandnpm run lint— passed, no fixes needed.Full-repository tests and local Electron E2E were not run; CI covers its selected surfaces.
AI use
Tool(s) and scope: Maka (gpt-6.1-sol) diagnosed the failures, updated the test fixture, and ran verification.
Checklist
Does this PR entail a change in behavior?