Repository navigation
fix(ui): let New project choose a folder without a custom name - #6060
Master-Frank wants to merge 1 commit into
Conversation
Creating a project required typing a name before Choose folder would enable. An empty name is a valid choice: the catalog already names the project after the folder when projects.add is called without one. Leave the name field optional, keep Choose folder available, and pass a trimmed name through only when one was typed. Update en / zh-CN / zh-TW copy to match. Fixes apache#6047
|
Thanks for following up. I'm closing this one for the same reason as #6059. The tree of this PR's commit ( The fix itself for #6047 is welcome. If you would like to continue, please re-create the change with a different tool or by hand, and name the tool in the AI-use section of the PR description (it currently says generative tooling made a substantive contribution but does not say which). We will review it normally.
|
Summary
Creating a project in the desktop app required a custom name before Choose folder would enable. An empty name is a valid choice and means “name this project after the folder I pick.”
NewProjectDialognow submits with the name field empty. Choose folder stays available either way. A typed name is still trimmed and applied in the sameprojects.addstep; a blank name is omitted so the existing folder-basename fallback inprojects.addapplies. The en / zh-CN / zh-TW copy no longer says the name has to come first.Fixes #6047
Verification
npx biome checkon the changed filesnpm --workspace @maka/ui run buildandnode --test packages/ui/dist/__tests__/new-project-dialog.test.js(4 pass)node --test packages/ui/dist/__tests__/conversation-copy.test.js(7 pass)npm run check:locale-hygienetsc -p apps/desktop/tsconfig.renderer.json --noEmit)node --test --test-force-exit apps/desktop/dist/main/__tests__/project-add-restore.test.js apps/desktop/dist/main/__tests__/task-entry-provider-scope.test.js apps/desktop/dist/main/__tests__/task-entry-controller.test.js(80 pass), including the new “Settings Add with a blank name still opens the folder picker” caseNot run: Electron desktop app / native folder picker. Those are not available in this environment; the behavior is covered by the dialog and Settings registration tests.
AI use
Select exactly one:
Checklist
Does this PR entail a change in behavior?