perf: reuse reactor projects in remote resources - #307
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse Maven reactor projects when resolving the project list exposed to remote-resource templates, avoiding a redundant model build for each matching reactor dependency.
Changes
Testing
mvn -DskipITs -Dspotless.skip=true -Dtest=RemoteResourcesMojoTest test— passed (12 tests)mvn -DskipITs -Dspotless.skip=true verify— passedgit diff --check— passedmvn -Dspotless.skip=true -Prun-its verify— core integration tests passed, but the build finished failed because the local JDK 27 is incompatible with the repository's Groovy post-build scripts (Unsupported class file major version 71).Refs #270