Skip to content

Fix Maven compile panel to respect Maven default JDK#9467

Open
NicolaIsotta wants to merge 1 commit into
apache:masterfrom
NicolaIsotta:issue3928
Open

Fix Maven compile panel to respect Maven default JDK#9467
NicolaIsotta wants to merge 1 commit into
apache:masterfrom
NicolaIsotta:issue3928

Conversation

@NicolaIsotta

@NicolaIsotta NicolaIsotta commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

When the Maven default JDK differed from the IDE default JDK, the compile panel's Java Platform combo-box would show the IDE default, while Maven actually used its own configured default to build. This could be misleading to the user and might cause builds to fail.

The combo-box now correctly reflects the Maven default JDK and labels it as "(Maven default)" when it differs from the IDE default.

Fixes #3928


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

LLMs, Commit messages and PR description:

  • Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
  • LLM assisted commits should be attributed with an Assisted-by: MODEL_NAME MODEL_VERSION line appended to the commit message.
    • Please mention coding assistance in the PR description too (eg. by adding the same Assisted-by line from above)
    • Please describe the changes in your own words - we'd like to know you understand the changes being made!

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

When the Maven default JDK differed from the IDE default JDK, the
compile panel's Java Platform combo-box would show the IDE default,
while Maven actually used its own configured default to build. This could be misleading to the user e might caused builds to fail.

The combo-box now correctly reflects the Maven default JDK and labels
it as "(Maven default)" when it differs from the IDE default.

Fixes apache#3928
@NicolaIsotta

Copy link
Copy Markdown
Contributor Author

Steps to test/reproduce can be adapted from #3928

For reference, here's the current behavior:
image
Here's how the panel appears with the PR applied:
image

@mbien mbien added Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jun 24, 2026
@apache apache locked and limited conversation to collaborators Jun 24, 2026
@apache apache unlocked this conversation Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven project: Java Platform from Project Properties is ignored

2 participants