[core] Cover snapshot sequence bucket rescale check#8286
Merged
Conversation
Contributor
|
Reviewed the change and the added coverage. The widened same-bucket check is scoped to APPEND commits on fixed hash buckets and now also covers write-only snapshot sequence initialization, which is the path that can otherwise skip restoring previous file metadata during writes. OVERWRITE still bypasses the check, so the supported bucket-rescale flow remains available. I also ran the focused core regression test locally:
LGTM from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes write-only snapshot sequence APPEND commits participate in the same bucket-number consistency check as unordered write-only append commits. It prevents INSERT INTO from writing new files with a rescaled bucket count before existing data layout is rewritten, while INSERT OVERWRITE can still be used to rescale the layout.
Tests
git diff --check HEAD^ HEADmvn -s ~/.m2/apache-community.xml -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=FileStoreCommitTest#testWriteOnlySnapshotSequenceCommitChecksRescaledBucketNumber test