You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
It looks like the Jenkinsfile and Dockerfile have changed and been optimized in the latest commits. I need to rebase with the latest changes and check on this task.
@Aggarwal-Raghav, if we want to test Tez with JDK 25, which fields in the latest Jenkinsfile and Dockerfile do we need to modify? As far as I can see in the latest changes, there are no fields related to the JDK version.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
@maheshrajus , now the spotbugs have failed because its incompatible with jdk25. I'll investigate it in some time to see which is better approach (maven-shading or apache pom version) from my perspective and share my findings as both have some tradeoffs in terms of error
This much of the patch should be enough. It is passing in local. Regarding ubi10 (RHEL10) in docker image, I don't have any strong opinion on that. Also update the README.md or other docs/md where JDK version, spotbugs tools etc. version are mentioned. For example:
@Aggarwal-Raghav All checkstyle issues related to jdk 25 so better to include in this PR itself.
@abstractdog Could you please review the PR at your convenience?
Thank you !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.