tests: remove invalid used memory assertion - #263
Open
massimomazzariol wants to merge 1 commit into
Open
massimomazzariol wants to merge 1 commit into
massimomazzariol wants to merge 1 commit into
Conversation
Owner
|
Shouldn't we keep it an just fix the value? |
Contributor
Author
Sorry I just double-checked the original commit and I think my first assumption was wrong. The confusing part is that the condition uses |
Owner
|
100 (one hundred) MegaBytes should be exceeded in a stock firmware |
Signed-off-by: Massimo Mazzariol <mazzariol.massimo@gmail.com>
aparcar
force-pushed
the
fix-used-memory-assertion
branch
from
September 29, 2026 17:40
1870e52 to
b96d66a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at the base tests I noticed that
test_free_memory()contains this assertion:free -mreports memory in MiB, so this currently requires the device to use more than 10 GB of memory, while the assertion message mentions 100 MB.The test already stores the measured value in
results_bag, and the commit that originally added it describes the purpose as storing used memory after startup.This removes the inconsistent assertion and keeps the memory measurement in
results_bag.