Repository navigation
Conversation
Draft POC for #1299. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 12/16 — pr-open-and-ready, max-files, max-lines, no-risky-content |
| Review findings | ✅ none |
| Reviewer escalation | ❌ Adds a new public apify server command group that sends the user's API token to Actor-controlled standby hosts and changes run/push runtime behavior, with open design questions still listed in the PR. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
pr-open-and-ready: PR is a draftmax-files: 14 changed files, limit 10max-lines: 1325 changed lines (+1223/-102), limit 200no-risky-content: src/commands/run.ts: network call (network-call); src/commands/server/request.ts: network call (network-call); src/lib/server-actor.ts: network call (network-call)
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 0c39d9eb3 · workflow run
|
This is a quick draft of server actors support of CLI.
@DaveHanns @patrikbraborec @jancurn pls take a look and let me know if you see some UX problems from user point of view (naming/flow) |
|
Hi, thanks! One thing, we want to get rid of standby naming. Let's rename the following command: Ideally something like: The best thing would be that the CLI recognize the server actor, ie based on |
Draft for #1299
Open questions
Q1:
apify createsuggestsapify runfor standby templatesapify create my-actor -t ts-standbyends withNext steps: … apify run. The template setsusesStandbyMode: true, so the command that runs it the way the platform does isapify run --standby.apify runnow prints a hint pointing to--standby, butcreatesends the user to the wrong command first.buildNextSteps()always pushesapify run(create-utils.ts#L95).Important
Should
createsuggestapify run --standbywhen the created Actor hasusesStandbyMode: true?Q2:
server statusshows pool settings to callers of multi-tenant ActorsFor a multi-tenant Actor,
statusprintsMemory,Idle timeoutandRequests/runin the same form as for a single-tenant Actor. For single-tenant they decide the caller's cost: runs start in the caller's account, and the caller can override them with a task. For multi-tenant they describe the developer's pool: the caller pays per event only and cannot change them, because tasks do not work with multi-tenant Actors. When the caller owns the Actor, they are exactly what the owner pays for.Important
Pool (developer's account):, orPool (your account):for the owner ?Related: for multi-tenant Actors,
statusskips the run lookup. The owner could see the pool runs (standby.deployment: MULTI_TENANT_*); a caller cannot.Manual test
Published
ts-standbytemplate (single-tenant)Updated
ts-standbytemplate (containerPort,webServerSchema; separate actor-templates change)Rejected before sending
Multi-tenant (
apify/web-fetch)🤖 Generated with Claude Code