Repository navigation
test: tidy the proxy conformance lane - #467
Merged
Merged
Conversation
Follow-up to #464. List `dns-rebinding-protection` in the conformance coverage table, honour the workflow's `verbose` input in the proxy lane like the client lane does, and spawn `npx` through a shell on Windows, where it is a .cmd shim that Node refuses to spawn directly (EINVAL). Refs #334 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BbA1fNDr3b1HbZc7Q6qFvo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #464 covering the nits from its review. Test-only, no runtime change.
dns-rebinding-protectionin the conformance coverage table intest/conformance/README.mdverboseinput, like the client lanenpxthrough a shell on Windows, where it is a.cmdshim that Node refuses to spawn directly (EINVAL)Verified locally: the lane still passes 2/2 with
--verbose --output-dirpassed through, lint, build and unit tests are green.Refs #334
Generated by Claude Code