Skip to content

deps: fallow 3.18.0 -> 3.19.0 (kahraman 0.3.1 + storybook 10.5.10 already landed via #40 rebase) - #41

Open
Guria wants to merge 5 commits into
mainfrom
agent/karkas-fallow-319-a41b77c2
Open

deps: fallow 3.18.0 -> 3.19.0 (kahraman 0.3.1 + storybook 10.5.10 already landed via #40 rebase)#41
Guria wants to merge 5 commits into
mainfrom
agent/karkas-fallow-319-a41b77c2

Conversation

@Guria

@Guria Guria commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

After #40 rebase-merged, 25fe156 (kahraman 0.3.1 + storybook 10.5.10) and ba0ce46 (lucide-react 1.34.0) are already on main. Remaining diff of this PR is only the fallow ^3.18.0 -> ^3.19.0 bump (package.json + lockfile).

merge commit 65149d5: pnpm-lock.yaml regenerated via nub install for fallow 3.19.0, changeset file taken scalar from #44 fix. CI test + CodeRabbit pass, MERGEABLE/CLEAN, 416/416 tests.

[Hermi 🤖 — from hermi.exe.xyz]

kahraman 0.3.1 aligns its dev toolchain (changesets 3, storybook 10.5.10);
storybook 10.5.8 -> 10.5.10 rides the same peer set. @ark-ui/react 5.39.0
was tested and reverted: CollectionSelect onValueChange stops updating the
stock filter (Items.stories 'No Matching Items' tests fail 2/47). fallow
3.19.0 deferred behind the repo minimumReleaseAge=1440 gate until it ages in.

[Hermi 🤖 — from hermi.exe.xyz]
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 78bab6ea-5f09-4483-acc7-334db7255898

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0dc4ab7f-f700-46a2-86d0-4766fc6402da

📥 Commits

Reviewing files that changed from the base of the PR and between ed429e2 and 65149d5.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates the fallow development dependency constraint in package.json from ^3.18.0 to ^3.19.0.

Changes

Fallow dependency update

Layer / File(s) Summary
Dependency version update
package.json
The fallow development dependency constraint changes from ^3.18.0 to ^3.19.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to 65149

The dependency update selects fallow 3.19.0 for the development toolchain; merge readiness still depends on confirming the supported Node.js version and that the 1,440-minute release-age policy is satisfied. This is a bounded non-production risk, so the PR is mergeable with explicit owner follow-up.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the dependency update from fallow 3.18.0 to 3.19.0. This matches the summarized package.json change, although the parenthetical rebase context is extra.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/karkas-fallow-319-a41b77c2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Fallow audit report

No GitHub PR/MR findings.

Generated by fallow.

lucide-icons/lucide#4722 adds mail-clock icon; no API or peer changes, react ^19 still satisfied. Manifests keep ^1.31.0/^1.21.0; lockfile refreshes the workspace resolution to 1.34.0 via nub update (minimumReleaseAge-respecting). mise run ci green.
Changelog-read: 3.19.0 adds fallow agent install + MCP resources; no
breaking changes for repo usage (setup-hooks deprecation only, still
works through 3.x). Gate: published 26T18:08Z, minReleaseAge 24h lifted.

[Hermi 🤖 — from hermi.exe.xyz]
Guria pushed a commit that referenced this pull request Aug 28, 2026
The list form ("@karkas/demo":\n  - patch) fails changesets v3 parsing
with: could not parse changeset - invalid release type, expected a
string. Release workflow on main has been red since 25fe156.
Introduced by #41.
@Guria

Guria commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto main (merge commit resolving pnpm-lock.yaml conflict via nub install regeneration; changeset file now uses the scalar form from #44). Local nub run test: first run 415/416 (one kahraman timing flake in Settings Save-Profile-Error story), rerun 416/416 green. Ready for merge. [Hermi 🤖 — from hermi.exe.xyz]

@Guria Guria changed the title deps: kahraman 0.3.1 + storybook 10.5.10 (ark-ui held at 5.38.1) deps: fallow 3.18.0 -> 3.19.0 (kahraman 0.3.1 + storybook 10.5.10 already landed via #40 rebase) Aug 28, 2026
Guria pushed a commit that referenced this pull request Aug 29, 2026
Changelog lucide-icons/lucide (1.35.0): icon additions/changes only, no API
changes. minimumReleaseAge=1440: published 2026-08-28T07:10Z, gate lifted
2026-08-29T07:10Z (verified via npm view time before fold).

The 1.35.0 button role/name regression in Settings Save-Profile (previously
reproduced on the #41-era baseline) no longer reproduces: Settings.stories.tsx
47/47 green pre- and post-fold; full mise run ci green (RC=0).

Lockfile surgical edit: nub update hard-fails on fastq@1.20.2 trustPolicy
no-downgrade and mangles the lockfile; hand-applied version+integrity swap
(integrity from npm view dist.integrity), validated by frozen-lockfile install
and full CI.

[Hermi 🤖 — from hermi.exe.xyz]
Changelog (fallow-rs/fallow v3.20.0): Yarn PnP resolution, project-reference
tsconfig scope fix, review-brief schema 8 (additive), coverage matching. Known
behavior changes verified harmless here: strict-run exit-code flip only affects
configs with per-path overrides (none), referenced-tsconfig scope fix surfaced
no new unresolved-import findings (lint:fallow + health green).

Surgical pnpm-lock edit: nub re-resolution blocked by fastq@1.20.2 trust gate
(manual publish, no trusted-publisher evidence) - needs Guria decision for
trustPolicyExclude. Only the fallow subtree touched (fallow, fallow-type-aware,
8 @fallow-cli/* platform bins), integrity strings from registry metadata.

mise run ci: green (all tasks, FINAL_RC=0).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant