Repository navigation
fix: reject invalid x5c chain lengths before parsing - #302
visheshupadhyay wants to merge 2 commits into
Conversation
dxnnystyles
left a comment
There was a problem hiding this comment.
nice addition with the early null guard! one case missing from the new tests is verifyChain(null, ...). since this changes a NullPointerException into INVALID_CHAIN_LENGTH, an assertion for that exact input would help protect the new behavior :)
|
Thanks for catching that, @dxnnystyles. I’ve added explicit coverage for I also ran the focused |
dxnnystyles
left a comment
There was a problem hiding this comment.
thanks for adding this! I checked the updated test, and it now covers verifyChain(null, ...) with the expected INVALID_CHAIN_LENGTH status. the early rejection also prevents certificate parsing for invalid chain lengths. looks good!
Fixes #301