Skip to content

fix: enforce integer validation for AppTransaction appAppleId and versionExternalIdentifier #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utkarshpatwa393-sys wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −2
Open

fix: enforce integer validation for AppTransaction appAppleId and versionExternalIdentifier #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions models/AppTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class AppTransactionValidator implements Validator<AppTransaction> {
if (typeof obj !== 'object' || obj === null || Array.isArray(obj)) {
return false
}
if ((typeof obj['appAppleId'] !== 'undefined') && !(typeof obj['appAppleId'] === "number" || obj['appAppleId'] instanceof Number)) {
if ((typeof obj['appAppleId'] !== 'undefined') && !((typeof obj['appAppleId'] === "number" || obj['appAppleId'] instanceof Number) && Number.isInteger(obj['appAppleId'].valueOf()))) {
return false
}
if ((typeof obj['appTransactionId'] !== 'undefined') && !(typeof obj['appTransactionId'] === "string" || obj['appTransactionId'] instanceof String)) {
Expand Down Expand Up @@ -153,7 +153,7 @@ export class AppTransactionValidator implements Validator<AppTransaction> {
if ((typeof obj['applicationVersion'] !== 'undefined') && !(typeof obj['applicationVersion'] === "string" || obj['applicationVersion'] instanceof String)) {
return false
}
if ((typeof obj['versionExternalIdentifier'] !== 'undefined') && !(typeof obj['versionExternalIdentifier'] === "number" || obj['versionExternalIdentifier'] instanceof Number)) {
if ((typeof obj['versionExternalIdentifier'] !== 'undefined') && !((typeof obj['versionExternalIdentifier'] === "number" || obj['versionExternalIdentifier'] instanceof Number) && Number.isInteger(obj['versionExternalIdentifier'].valueOf()))) {
return false
}
if ((typeof obj['deviceVerification'] !== 'undefined') && !(typeof obj['deviceVerification'] === "string" || obj['deviceVerification'] instanceof String)) {
Expand Down
26 changes: 26 additions & 0 deletions tests/unit-tests/AppTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,30 @@ describe('AppTransaction', () => {

expect(validator.validate(appTransaction)).toBe(true)
})

it('should accept AppTransaction with valid integer appAppleId and versionExternalIdentifier', () => {
const validator = new AppTransactionValidator()
const validAppTransaction = {
appAppleId: 531412,
versionExternalIdentifier: new Number(12345),
}

expect(validator.validate(validAppTransaction)).toBe(true)
})

it('should reject AppTransaction with non-integer appAppleId', () => {
const validator = new AppTransactionValidator()

expect(validator.validate({ appAppleId: 123.45 })).toBe(false)
expect(validator.validate({ appAppleId: NaN })).toBe(false)
expect(validator.validate({ appAppleId: Infinity })).toBe(false)
})

it('should reject AppTransaction with non-integer versionExternalIdentifier', () => {
const validator = new AppTransactionValidator()

expect(validator.validate({ versionExternalIdentifier: 12.34 })).toBe(false)
expect(validator.validate({ versionExternalIdentifier: NaN })).toBe(false)
expect(validator.validate({ versionExternalIdentifier: Infinity })).toBe(false)
})
})