Conversation
Add a failable init?(uuidString:) that parses the canonical hyphenated 8-4-4-4-12 hexadecimal UUID string form.
gakiwate
requested review from
agnosticdev,
ekinnear and
tfpauly
as code owners
October 2, 2026 21:24
agnosticdev
reviewed
Oct 3, 2026
agnosticdev
left a comment
agnosticdev
left a comment
Collaborator
There was a problem hiding this comment.
Could you add a few tests here too?
| /// `E621E1F8-C36C-495A-93FC-0C247A3E6E5F`), or nil when `uuidString` is not 36 | ||
| /// characters in the 8-4-4-4-12 hexadecimal layout. | ||
| public init?(uuidString: String) { | ||
| let ascii = Array(uuidString.utf8) |
Collaborator
There was a problem hiding this comment.
Can we use uuidString.withCString here instead of creating a temporary array?
Maybe something like:
let isValid = uuidString.withCString { cString -> Bool in
var byteIndex = 0
var i = 0
while i < 36 {
let char = UInt8(bitPattern: cString[I])
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a failable init?(uuidString:) that parses the canonical hyphenated 8-4-4-4-12 hexadecimal UUID string form.