Skip to content

Fix Settings test storage cleanup on Node 26 - #190

Merged
31b4 merged 1 commit into
mainfrom
bug/189-settings-test-storage
Oct 28, 2026
Merged

31b4 merged 1 commit into
mainfrom
bug/189-settings-test-storage

Conversation

@31b4

@31b4 31b4 commented Oct 28, 2026

Copy link
Copy Markdown
Member

Closes #189

Summary

Fix four Settings preference tests failing on Node 26 after cleanup removes the shared localStorage mock. Reinstate the setup-provided storage before each test so the simulated storage-write failure and global cleanup cannot leave subsequent tests using Node's unavailable native storage.

Changes

  • Capture the working storage fixture and explicitly reinstall it in each test setup.
  • Keep global cleanup and storage-failure coverage intact.

Verification

  • Reproduced the original four failures on Node 26.5.0 before the fix.
  • Settings preferences: all 5 tests pass on Node 22.23.2 and Node 26.5.0 after the fix.
  • Full client suite on Node 26.5.0: 63 files, 582 tests pass.
  • Client lint with zero warnings and git diff --check pass.

@31b4
31b4 merged commit bf8e0b7 into main Oct 28, 2026
10 checks passed
@31b4
31b4 deleted the bug/189-settings-test-storage branch October 28, 2026 11:29
@31b4 31b4 mentioned this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Settings test storage cleanup on Node 26

1 participant