Skip to content

Require complete CI before merging to main - #192

Merged
31b4 merged 1 commit into
mainfrom
task/191-enforce-ci-before-merge
Oct 28, 2026
Merged

31b4 merged 1 commit into
mainfrom
task/191-enforce-ci-before-merge

Conversation

@31b4

@31b4 31b4 commented Oct 28, 2026

Copy link
Copy Markdown
Member

Closes #191

Summary

PR #188 merged after its Node 26 client check had failed because main required no status checks. Make the complete existing CI suite a mandatory merge gate through a separate CI-only ruleset, including for administrators.

The GitHub setting is already active: https://github.com/apptrackit/finance/rules/26035750. This PR records that policy and documents its operation; merging the JSON itself does not change GitHub settings.

Changes

  • Track an active main-branch ruleset requiring CI passed from the verified GitHub Actions application (15368), with no bypass actors and strict up-to-date checks.
  • Preserve existing review, force-push and deletion protection. Administrator review exemptions are unchanged; CI cannot be bypassed through them.
  • Document live-policy auditing, aggregate job dependencies, the pinned deployment runtime, and the distinction between CI coverage and local/production deployment checks.

Verification

  • Read back the ruleset and programmatically compared every configured field with the tracked JSON: matched.
  • Queried effective rules for main: the required aggregate check, provider and strict policy are active.
  • Compared existing branch protection before/after: identical.
  • git diff --check passed. No application/test/build code changed, so application suites were not rerun.

Failure evidence: https://github.com/apptrackit/finance/actions/runs/40679019517/job/122784657088

@31b4
31b4 merged commit 2f0aa2a into main Oct 28, 2026
11 checks passed
@31b4
31b4 deleted the task/191-enforce-ci-before-merge branch October 28, 2026 11:56
@31b4 31b4 mentioned this pull request Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require successful complete CI before merging to main

1 participant