Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199
Summary
This PR fixes the Critical and High findings from an Apple Human Interface Guidelines design review of the whole client. It covers contrast and minimum text size, consistent money and date formatting, following the system appearance, mobile navigation and header, a calmer Analytics page, animated dialogs that behave as swipeable sheets on phones, and consistent category icons. Financial behavior, API and MCP are unchanged: category icons are still stored as emoji, and only their rendering changes.
Changes
--primary-filltoken (Original dark only,#2d6dc8) brings white labels on filled controls from 3.55:1 to 5.08:1. The dark--destructivechanges to#eb4747, bringing red text on cards from 4.03:1 to 5.09:1. Other themes are unchanged.text-[9px]/text-[10px]are removed. Sub-12px text is now 12px, except uppercase labels at 11px. Chart axes move to 11px.lib/format.ts(formatNumber,formatMoney,formatCompactNumber,formatPercent,formatDate,formatDateTime,formatTime). It always groups digits, uses a decimal comma, a true minus (U+2212), currency codes after the number, K/M/B compact suffixes, English dates and a 24-hour clock. About 70 call sites across Dashboard, Accounts, sidebar, Analytics, Investments, Recurring and Search use it. Editable inputs still uselib/amount.ts.prefers-color-schemelive), with Light/Dark overrides in Settings. An explicit saved light/dark preference is still honored. The sidebar, More and mobile header theme toggles are removed.Modalnow animates withframer-motion, which was already a dependency. The previousanimate-inclasses came from a plugin that isn't installed and did nothing. Phone sheets slide up, have a grabber, and dismiss on a downward swipe using momentum projection. Desktop dialogs scale and fade, drawers slide from the side, and reduced motion uses a crossfade. Tests run animations instantly throughMotionGlobalConfig.skipAnimations.CategoryIconmaps the stored emoji to Lucide line icons, falling back to a tag for unknown values. Transactions, calendar, Recurring, Top Expenses, breakdowns, the widget menus and the Settings icon picker use it. Emoji prefixes are removed from native<option>s and Money Map labels.lib/format.tsand the system-appearance behavior.Verification
npm test -w client: 592/592 pass.(cd client && npx tsc -b): clean.npm run lint -w client -- --max-warnings=0: clean.VITE_API_AUTH_MODE=public VITE_API_DOMAIN=localhost:8787 npm run build: succeeds.