Repository navigation
Conversation
The Needs review confirmation preview added the account balance and pending deltas with floating-point addition. Since amounts keep their saved precision (#198), the residue became visible, e.g. 8968.53 - 6.40 shown as 8962.130000000001. Sum the preview and split group totals with the shared decimal helper instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
Summary
Dashboard review previews exposed floating-point residue because they summed saved balances and pending amounts with ordinary addition. Calculate preview balances and split totals with the existing decimal arithmetic helper while preserving stored amount precision.
Changes
Verification