Repository navigation
feat: Android SDK update for version 30.0.0 - #140
ChiragAgg5k wants to merge 2 commits into
Conversation
馃數 Tier A 路 Mergeable after minor fixes
Updates the Android SDK to Appwrite API 2.4 and SDK version 30.0.0, adding passkey and analytics endpoints and updating OAuth2 and team membership APIs. It also adds model defaults for omitted response fields and refreshes the corresponding examples and release documentation. 1 of 122 changed files was too large to include in full.
Note Not approving while a bug finding is open: Encode OAuth state before adding it to the URL
Fix with agent prompt### Issue 1
library/src/main/java/io/appwrite/services/Account.kt:2018
**Encode OAuth state before adding it to the URL**
Both OAuth helpers interpolate their parameters directly into the query string (here and in `createOAuth2Token`), while `state` allows printable ASCII. A state containing `&` or `#` is parsed as another query parameter or a fragment, so the server receives a different state and callback verification fails; construct the URL with properly encoded query parameters.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.馃搨 Walkthrough 路 8
Reviewed |
| "success" to success, | ||
| "failure" to failure, | ||
| "scopes" to scopes, | ||
| "state" to state, |
There was a problem hiding this comment.
Encode OAuth state before adding it to the URL
Both OAuth helpers interpolate their parameters directly into the query string (here and in createOAuth2Token), while state allows printable ASCII. A state containing & or # is parsed as another query parameter or a fragment, so the server receives a different state and callback verification fails; construct the URL with properly encoded query parameters.
Prompt To Fix With AI
This is a comment left during a code review.
Path: library/src/main/java/io/appwrite/services/Account.kt
Line: 2018
Comment:
**Encode OAuth state before adding it to the URL**
Both OAuth helpers interpolate their parameters directly into the query string (here and in `createOAuth2Token`), while `state` allows printable ASCII. A state containing `&` or `#` is parsed as another query parameter or a fragment, so the server receives a different state and callback verification fails; construct the URL with properly encoded query parameters.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.馃煛 Minor 路 bug 路 Reply if this doesn't apply.
|
Superseded: replaced by a passkeys-only minor release. |
This PR contains updates to the Android SDK for version 30.0.0.