Skip to content

feat: SDK update for version 29.1.0 - #141

Merged
ChiragAgg5k merged 1 commit into
29.xfrom
release/29.1.0
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
29.xfrom
release/29.1.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 29.1.0.

What's Changed

  • Added: account passkey methods listPasskeys, createPasskey, getPasskey, updatePasskey, deletePasskey and updatePasskeyVerification
  • Added: account.createPasskeyToken and account.updatePasskeyToken for passkey sign-in
  • Added: Passkey, PasskeyList, PasskeyChallenge and TokenSecret models

Passkeys only, patched onto 29.0.0: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including its X-Appwrite-Response-Format.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The Java passkey examples need a small correction to compile and run across the SDK's supported Android versions.

Adds passkey management and sign-in methods, along with their response models, to the Android SDK. It also updates the 29.1.0 release information and adds Java and Kotlin usage examples.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Java passkey snippets don't compile on the supported Android range docs/examples/java/account/list-passkeys.md:15
Fix with agent prompt
### Issue 1
docs/examples/java/account/list-passkeys.md:15
**Java passkey snippets don't compile on the supported Android range**

The new Java examples use `List`/`Map` without importing them, so they do not compile as shown. Also, `List.of` and `Map.of` are unavailable below Android API 30, while this SDK supports API 24+; use API-compatible collection factories and include the required imports.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 4
File Change
CHANGELOG.md, README.md, library/src/main/java/io/appwrite/Client.kt Updates release notes, dependency examples, and the SDK version header.
library/src/main/java/io/appwrite/services/Account.kt Adds account passkey management, verification, and sign-in token endpoints.
library/src/main/java/io/appwrite/models/Passkey.kt, library/src/main/java/io/appwrite/models/PasskeyChallenge.kt, library/src/main/java/io/appwrite/models/PasskeyList.kt, library/src/main/java/io/appwrite/models/TokenSecret.kt Adds passkey, challenge, list, and token response models.
docs/examples/java/account/*.md, docs/examples/kotlin/account/*.md Adds Java and Kotlin passkey endpoint examples.

Reviewed 2a37115 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Account account = new Account(client);

account.listPasskeys(
List.of(), // queries (optional)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java passkey snippets don't compile on the supported Android range

The new Java examples use List/Map without importing them, so they do not compile as shown. Also, List.of and Map.of are unavailable below Android API 30, while this SDK supports API 24+; use API-compatible collection factories and include the required imports.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/java/account/list-passkeys.md
Line: 15

Comment:
**Java passkey snippets don't compile on the supported Android range**

The new Java examples use `List`/`Map` without importing them, so they do not compile as shown. Also, `List.of` and `Map.of` are unavailable below Android API 30, while this SDK supports API 24+; use API-compatible collection factories and include the required imports.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · documentation · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit a3f3e11 into 29.x Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant