Repository navigation
feat: SDK update for version 29.1.0 - #141
Conversation
🔵 Tier A · Mergeable after minor fixes
Adds passkey management and sign-in methods, along with their response models, to the Android SDK. It also updates the 29.1.0 release information and adds Java and Kotlin usage examples.
Fix with agent prompt### Issue 1
docs/examples/java/account/list-passkeys.md:15
**Java passkey snippets don't compile on the supported Android range**
The new Java examples use `List`/`Map` without importing them, so they do not compile as shown. Also, `List.of` and `Map.of` are unavailable below Android API 30, while this SDK supports API 24+; use API-compatible collection factories and include the required imports.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 4
Reviewed |
| Account account = new Account(client); | ||
|
|
||
| account.listPasskeys( | ||
| List.of(), // queries (optional) |
There was a problem hiding this comment.
Java passkey snippets don't compile on the supported Android range
The new Java examples use List/Map without importing them, so they do not compile as shown. Also, List.of and Map.of are unavailable below Android API 30, while this SDK supports API 24+; use API-compatible collection factories and include the required imports.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/java/account/list-passkeys.md
Line: 15
Comment:
**Java passkey snippets don't compile on the supported Android range**
The new Java examples use `List`/`Map` without importing them, so they do not compile as shown. Also, `List.of` and `Map.of` are unavailable below Android API 30, while this SDK supports API 24+; use API-compatible collection factories and include the required imports.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
This PR contains updates to the SDK for version 29.1.0.
What's Changed
accountpasskey methodslistPasskeys,createPasskey,getPasskey,updatePasskey,deletePasskeyandupdatePasskeyVerificationaccount.createPasskeyTokenandaccount.updatePasskeyTokenfor passkey sign-inPasskey,PasskeyList,PasskeyChallengeandTokenSecretmodelsPasskeys only, patched onto
29.0.0: the diff of the SDK generated with and without the passkey methods, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.