Repository navigation
feat: SDK update for version 29.2.0 - #142
Merged
Merged
Conversation
🟢 Tier S · Ready to mergeUpdates the Android SDK to version 29.2.0 with an Analytics event endpoint, optional OAuth state and team membership ID parameters, and PUT-based avatar photo uploads. It also updates the README, changelog, and Java/Kotlin examples, and URL-encodes OAuth query keys and values so reserved characters survive redirects. Latest changes: The latest commits URL-encode keys and values in both OAuth2 flows, covering redirect URLs, scopes, and state, and document that fix in the changelog.
📂 Walkthrough · 15
✅ Fixed since the last review · 1
Reviewed the commits since |
A state, success or failure value containing &, +, # or = was concatenated raw into the OAuth2 URL and did not round-trip. Encode each key and value with Uri.encode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the SDK for version 29.2.0.
What's Changed
analytics.createEventin a newAnalyticsservice to send tracking eventsstateonaccount.createOAuth2Sessionandaccount.createOAuth2Token, returned unchanged on the success and failure URLsmembershipIdonteams.createMembershipavatars.updatePhotosendsPUT, so uploading a profile photo no longer returns 404success,failure,scopes,state) are URL-encoded, so values containing&,+or#survive the redirectPatched onto
29.1.0: the diff of the SDK generated with and without these features, three-way merged onto the release. Everything else on the release is unchanged, including itsX-Appwrite-Response-Format.membershipIdis the last parameter ofteams.createMembership, so existing positional calls keep working.