Skip to content

feat: SDK update for version 29.1.0 - #170

Merged
ChiragAgg5k merged 1 commit into
29.xfrom
release-29.1.0
Oct 6, 2026
Merged

ChiragAgg5k merged 1 commit into
29.xfrom
release-29.1.0

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 29.1.0.

What's Changed

  • Added: optional state parameter on createOAuth2Token, returned unchanged on the success and failure URLs

This is a patch on top of 29.0.0: it adds only the state parameter from appwrite/appwrite#14157, plus the version bump and changelog. main is already at 30.0.0-rc.2, so this targets a 29.x branch cut from tag 29.0.0; 29.1.0 is released from 29.x.

Adds the optional state parameter to createOAuth2Token (appwrite/appwrite#14157).
@hansi-codes

hansi-codes Bot commented Oct 6, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The new state forwarding behavior needs regression coverage in the existing account tests.

Adds an optional OAuth2 state parameter to both object-style and positional createOAuth2Token calls and forwards it in the request query. Updates the example, changelog, package metadata, and client version identifiers for 29.1.0.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Add regression coverage for OAuth2 state forwarding src/services/account.ts:3013
Fix with agent prompt
### Issue 1
src/services/account.ts:3013-3015
**Add regression coverage for OAuth2 state forwarding**

The existing `createOAuth2Token` test in `test/services/account.test.js:1130` calls only the provider argument and returns a fixed redirect, so it would still pass if state were dropped. Please cover both calling styles, verifying the outgoing URL's decoded state (including query-special characters) and omission when state is undefined.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 6
File Change
CHANGELOG.md Documents the optional OAuth2 state parameter in the 29.1.0 release.
docs/examples/account/create-o-auth-2-token.md Adds state to the object-style usage example.
package.json Bumps the package version to 29.1.0.
package-lock.json Updates the root package version to 29.1.0.
src/client.ts Updates SDK version headers and user-agent identification.
src/services/account.ts Adds state to both overloads and forwards defined values to the OAuth2 request.

Reviewed 2d27edf · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment thread src/services/account.ts
Comment on lines +3013 to +3015
if (typeof state !== 'undefined') {
apiPayload['state'] = state;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add regression coverage for OAuth2 state forwarding

The existing createOAuth2Token test in test/services/account.test.js:1130 calls only the provider argument and returns a fixed redirect, so it would still pass if state were dropped. Please cover both calling styles, verifying the outgoing URL's decoded state (including query-special characters) and omission when state is undefined.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/account.ts
Line: 3013-3015

Comment:
**Add regression coverage for OAuth2 state forwarding**

The existing `createOAuth2Token` test in `test/services/account.test.js:1130` calls only the provider argument and returns a fixed redirect, so it would still pass if state were dropped. Please cover both calling styles, verifying the outgoing URL's decoded state (including query-special characters) and omission when state is undefined.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit e67d731 into 29.x Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant