Repository navigation
fix: bump undici to 6.28.1 to clear npm audit - #171
Merged
Merged
Conversation
… and GHSA-rfgv-xxqx-mfg5 npm audit --audit-level=high fails on undici <=6.28.0, so the 29.1.0 publish stopped before npm publish.
🟢 Tier S · Ready to merge
Raises the minimum undici version to 6.28.1 within the existing 6.x range to address the reported security advisories. The lockfile pins the updated version and retains the same Node.js engine requirement.
📂 Walkthrough · 2
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 29.1.0 publish failed at
npm audit --audit-level=high --omit=dev: undici<=6.28.0is high severity through GHSA-3wwx-pv8p-q78v, GHSA-r53p-7pc4-xj5r and GHSA-rfgv-xxqx-mfg5, all fixed in 6.28.1.package.json:undici^6.27.0→^6.28.1, so installs cannot resolve a vulnerable 6.xpackage-lock.json: only theundicientry (version, resolved, integrity) and the root range changeLocally:
npm ciaccepts the lockfile,npm audit --audit-level=high --omit=devreports 0 vulnerabilities,npm run buildpasses. 29.1.0 never reached npm, so after this merges the 29.1.0 tag and release are re-pointed to the fixed29.xand published.main(30.0.0-rc.2) has the same undici range and will need the same bump.